FINERACT-2549: Migrate ClientExternalIdTest from RestAssured to fineract-client-feign#5659
Open
Dpk376 wants to merge 1 commit intoapache:developfrom
Open
Conversation
Dpk376
changed the title
Dpk376
force-pushed
the
feature/FINERACT-2441-feign-migration-clientexternalid
branch
from
951ebad to
0133a7b
Compare
Dpk376
changed the title
Dpk376
force-pushed
the
feature/FINERACT-2441-feign-migration-clientexternalid
branch
3 times, most recently
from
bdd501e to
0f84a76
Compare
Dpk376
changed the title
Dpk376
force-pushed
the
feature/FINERACT-2441-feign-migration-clientexternalid
branch
from
1f7b357 to
0397054
Compare
adamsaghy
reviewed
Mar 26, 2026
|
|
||
| // Close Client action | ||
| jsonPayload = clientHelper.getCloseClientAsJSON(); | ||
| String jsonPayload = clientHelper.getCloseClientAsJSON(); |
Contributor
There was a problem hiding this comment.
WE dont need this anymore no? It should use fineract-client too!
Contributor
Author
There was a problem hiding this comment.
Fixed and Replaced all new ClientHelper(requestSpec, responseSpec) usages and the deprecated performClientActionUsingExternalId calls with direct feign calls using the new static methods ClientHelper.closeClient(), ClientHelper.reactivateClient(), ClientHelper.rejectClient(), and ClientHelper.activateClient(). The PostClientsClientIdRequest model was also updated with the required fields (closureDate, closureReasonId, reactivationDate, rejectionDate, rejectionReasonId)
Dpk376
force-pushed
the
feature/FINERACT-2441-feign-migration-clientexternalid
branch
2 times, most recently
from
9354c83 to
0ac8222
Compare
…act-client-feign - Migrates ClientExternalIdTest to use fineract-client-feign - Replaces RestAssured API calls with Feign client - Fixes obligeedetails endpoint handling for JSON array response - Updates OpenAPI schema accordingly
Dpk376
force-pushed
the
feature/FINERACT-2441-feign-migration-clientexternalid
branch
from
0ac8222 to
aa77864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Migrates
ClientExternalIdTestfrom the deprecated RestAssured-based helpers to the typed fineract-client-feign client, as part of FINERACT-2549.Changes
addClientAsPerson(),getClientByExternalId(),updateClientByExternalId(),deleteClientByExternalId(),getClientAccounts(),getProposedTransferDate(), andgetObligeeData()— usingFineractClientHelperandCalls.ok()requestSpec,responseSpec,getBasicClientAsJSON()); migrated all client create/get/update/delete calls to the new feign-based helpers; replaced manual JSON payload construction with typed request objects (e.g.PutClientsClientIdRequest)addClientAsPersoncalls to feign-based helpersaddClientAsPersonandgetClientAccountscalls to feign-based helpers@Deprecated(forRemoval = true)RestAssured methods fromClientHelperChecklist
./gradlew spotlessApplypassed./gradlew :integration-tests:compileTestJavapassedPart of FINERACT-2549
Related to FINERACT-2454
gsoc-fineract-evidence